bpo-44958: Only reset `sqlite3` statements when needed by erlend-aasland · Pull Request #27844 · python/cpython · GitHub

github.com

GitHub CopilotWrite better code with AI | MCP RegistryIntegrate external tools | ActionsAutomate any workflow | CodespacesInstant dev environments | IssuesPlan and track work | Code ReviewManage code changes | Code QualityEnforce quality at merge | Why GitHub | Marketplace | View all features | Enterprises | Small and medium teams | Startups | View all use cases | View all industries | View all solutions | AI | Software Development | DevOps | Security | View all topics | Customer stories | Events & webinars | Ebooks & reports | Business insights | Trust center | Partners | View all resources

Tin mới

erlend-aasland:sqlite-optimise-resets

GitHub CopilotWrite better code with AI

GitHub Copilot appDirect agents from issue to merge

ActionsAutomate any workflow

CodespacesInstant dev environments

IssuesPlan and track work

Code ReviewManage code changes

Code QualityEnforce quality at merge

GitHub Advanced SecurityFind and fix vulnerabilities

Code securitySecure your code as you build

Secret protectionStop leaks before they start

View all use cases

Financial services

View all industries

Software Development

GitHub SponsorsFund open source developers

Copilot for BusinessEnterprise-grade AI features

Premium SupportEnterprise-grade 24/7 support

Pull requests 2.6k

Security and quality 0

bpo-44958: Only reset sqlite3 statements when needed

gh-88239: Use sqlite3_stmt_busy() to determine if statements are in use #25984

bpo-43350: Don't reset active statements twice in _pysqlite_query_execute() #24681

We don't use the return value of pysqlite_statement_reset

If possible, avoid resetting unused statements

SQLITE_STMTSTATUS_RUN is available from 3.20.0 and onwards

Use sqlite3_stmt pointer iso. deref'ing self when calling sqlite3_reset

🔨 test-with-buildbots

🔨 test-with-buildbots

Merge branch 'main' into sqlite-optimise-resets

Sync with 'main' bco.

pysqlite_statement_reset result() is never used => return void

Merge branch 'main' into sqlite-optimise-resets

View reviewed changes

Learn more about hiding disruptive comments

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/pull/27844/files#r711816559

Check https://github.com/python/cpython/pull/27844/files#r711816559

Merge branch 'main' into sqlite-optimise-resets

Test that datamodifying select queries are marked readonly

View reviewed changes

bpo-44958: Fix ref. leak in test_table_lock_cursor_non_readonly_select()

bpo-44958: Fix ref. leak introduced in GH-27844 #28490

: Fix ref. leak introduced in

bpo-44958: Revert GH-27844 This reverts commit 050d1035957379d70e8601e6f5636637716a264b, but keeps the tests.

bpo-44958: Revert GH-27844 (GH-28574) This reverts commit 050d1035957379d70e8601e6f5636637716a264b, but keeps the tests.

[sqlite3] only reset statements when needed #89121

1/1