[3.8] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by gpshead · Pull Request #24881 · python/cpython

gpshead · GitHub

) bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address` attribute on your `ftplib.FTP` instance to True.. (cherry picked from commit

0ab152c

) Co-authored-by: Gregory P. Smith <[email protected]> Merged

miss-islington

pushed a commit to miss-islington/cpython that referenced this pull request

Mar 15, 2021

) (

pythonGH-24881

) bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address` attribute on your `ftplib.FTP` instance to True.. (cherry picked from commit

0ab152c

) Co-authored-by: Gregory P. Smith <[email protected]> (cherry picked from commit

664d1d1

) Co-authored-by: Gregory P. Smith <[email protected]>

miss-islington

pushed a commit to miss-islington/cpython that referenced this pull request

Mar 15, 2021

) (

pythonGH-24881

) bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address` attribute on your `ftplib.FTP` instance to True.. (cherry picked from commit

0ab152c

) Co-authored-by: Gregory P. Smith <[email protected]> (cherry picked from commit

664d1d1

) Co-authored-by: Gregory P. Smith <[email protected]>

ned-deily

pushed a commit that referenced this pull request

Mar 16, 2021

…H-24881

) (

GH-24882

) The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address` attribute on your `ftplib.FTP` instance to True.. (cherry picked from commit

0ab152c

) Co-authored-by: Gregory P. Smith <[email protected]> (cherry picked from commit

664d1d1

)

ned-deily

pushed a commit that referenced this pull request

Mar 16, 2021

…H-24881

) (

GH-24883

) The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address` attribute on your `ftplib.FTP` instance to True.. (cherry picked from commit

0ab152c

) Co-authored-by: Gregory P. Smith <[email protected]> (cherry picked from commit

664d1d1

)

gentoo-bot

pushed a commit to gentoo/cpython that referenced this pull request

Apr 3, 2021

) (

pythonGH-24881

) (

pythonGH-24882

) The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address` attribute on your `ftplib.FTP` instance to True.. (cherry picked from commit

0ab152c

) Co-authored-by: Gregory P. Smith <[email protected]> (cherry picked from commit

664d1d1

) Rebased for Python 2.7 by Michał Górny <[email protected]> Closed