gh-93476: Fraction.limit_denominator speed increase by mscuthbert · Pull Request #93477 · python/cpython · GitHub

github.com

Tin mới

mscuthbert:fractions_limit_denominator

GitHub CopilotWrite better code with AI

GitHub Copilot appDirect agents from issue to merge

ActionsAutomate any workflow

CodespacesInstant dev environments

IssuesPlan and track work

Code ReviewManage code changes

Code QualityEnforce quality at merge

GitHub Advanced SecurityFind and fix vulnerabilities

Code securitySecure your code as you build

Secret protectionStop leaks before they start

View all use cases

Financial services

View all industries

Software Development

GitHub SponsorsFund open source developers

Copilot for BusinessEnterprise-grade AI features

Premium SupportEnterprise-grade 24/7 support

Pull requests 2.6k

Security and quality 0

: Fraction.limit_denominator speed increases

Fix boundary case.

View reviewed changes

Learn more about hiding disruptive comments

The reason will be displayed to describe this comment to others. Learn more.

Review comments * Set variable naming according to existing cpython standards * confirm GCD of returned Fraction, and skip normalization * Respond and thanks to @mdickinson

View reviewed changes

return Fraction(self) for limit case

drop comment for now. can be separate PR

awaiting change review

Minor optimization for Fractions.limit_denominator

Minor optimization for Fractions.limit_denominator #93730

Minor optimization for Fractions.limit_denominator (

Revert 30935 defer bpo45162 to 312 (

emscripten-core/emscripten#17269

https://github.com/python/cpython/issue/89336

Increase speed of Fractions.limit_denominator

Successfully merging this pull request may close these issues.